Standalone example and integration test crates #160
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @nslee333, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly reorganizes the project's example binaries by extracting them into a dedicated top-level examples folder. This refactoring transforms each example into a standalone Rust package within the workspace, which enhances modularity and improves the overall project structure for better maintainability and clarity.
Highlights
- Example Structure Refactor: The
client,server, andperfexamples have been moved from therodbus/examples/directory to a new top-levelexamples/folder. - Individual Example Packages: Each example (
client,server,perf) is now configured as an independent Rust package within the workspace, each with its ownCargo.tomlfile. - Workspace Configuration Update: The root
Cargo.tomlhas been updated to include these newly structured example packages as members of the workspace. - Dependency Management: The
Cargo.lockfile has been updated to reflect the new dependencies introduced by the individual example packages, includinglock_api,parking_lot,redox_syscall, andsignal-hook-registry.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully extracts the examples into their own crates within a new examples directory, improving the project structure. My review includes suggestions to align the new example crates' dependencies with the workspace definitions for better maintainability and to fix minor formatting issues in the new Cargo.toml files.
| #[test] | ||
| fn address_start_max_count_of_one_is_allowed() { | ||
| AddressRange::try_from(std::u16::MAX, 1).unwrap(); | ||
| AddressRange::try_from(u16::MAX, 1).unwrap(); |
|
|
||
| pub(crate) unsafe fn bit_value_iterator_next( | ||
| it: *mut crate::BitValueIterator, | ||
| it: *mut crate::BitValueIterator<'_>, |
jadamcrain
changed the title
2 participants
Examples (examples/{client,server,perf}): Moved from rodbus/examples/*.rs to standalone workspace members with their own Cargo.toml files, each depending on rodbus via path
Integration tests (integration/): Extracted from rodbus/tests/ to a standalone test-only workspace member using explicit [[test]] targets
Dependency cleanup: Removed example/test-only dev-dependencies from rodbus/Cargo.toml (clap, tokio-stream, tokio-util, tracing-subscriber)
Linting improvements: Enabled unused_crate_dependencies linting in workspace, cleaned up dependency version formats